Re: [PATCH V2 Resend 3/4] workqueue: Schedule work on non-idle cpuinstead of current one
From: Tejun Heo
Date: Fri Jan 04 2013 - 10:09:20 EST
On Fri, Jan 04, 2013 at 04:41:47PM +0530, Viresh Kumar wrote:
> I got a list of files where cpu/processor_id strings are found, which
> may break with
> this patch (still can't guarantee as i don't have knowledge of these drivers)...
> I am not sure what to do now :) , can you assist ?
I don't know either. Changing behavior subtly like this is hard. I
usually try to spot some problem cases and try to identify patterns
there. Once you identify a few of them, understanding and detecting
other problem cases get a lot easier. In this case, maybe there are
too many places to audit and the problems are too subtle, and, if we
*have* to do it, the only thing we can do is implementing a debug
option to make such problems more visible - say, always schedule to a
different cpu on queue_work().
That said, at this point, the patchset doesn't seem all that
convincing to me and if I'm comprehending responses from others
correctly that seems to be the consensus. It might be a better
approach to identify the specific offending workqueue users and make
them handle the situation more intelligently than trying to impose the
behavior on all workqueue users. At any rate, we need way more data
showing this actually helps and if so why.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/