Re: [PATCH] pnfs: Increase the refcount when LAYOUTGET fails thefirst time

From: Myklebust, Trond
Date: Fri Jan 04 2013 - 10:51:31 EST

On Fri, 2013-01-04 at 20:19 +-0800, wrote:
+AD4- From: Yanchuan Nian
+AD4- The layout will be set unusable if LAYOUTGET fails. Is it reasonable to
+AD4- increase the refcount iff LAYOUTGET fails the first time?
+AD4- Signed-off-by: Yanchuan Nian
+AD4- ---
+AD4- fs/nfs/pnfs.c +AHw- 2 +--
+AD4- 1 files changed, 1 insertions(+-), 1 deletions(-)
+AD4- diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
+AD4- index e7165d9..d00260b 100644
+AD4- --- a/fs/nfs/pnfs.c
+AD4- +-+-+- b/fs/nfs/pnfs.c
+AD4- +AEAAQA- -254,7 +-254,7 +AEAAQA- static void
+AD4- pnfs+AF8-layout+AF8-set+AF8-fail+AF8-bit(struct pnfs+AF8-layout+AF8-hdr +ACo-lo, int fail+AF8-bit)
+AD4- +AHs-
+AD4- lo-+AD4-plh+AF8-retry+AF8-timestamp +AD0- jiffies+ADs-
+AD4- - if (test+AF8-and+AF8-set+AF8-bit(fail+AF8-bit, +ACY-lo-+AD4-plh+AF8-flags))
+AD4- +- if (+ACE-test+AF8-and+AF8-set+AF8-bit(fail+AF8-bit, +ACY-lo-+AD4-plh+AF8-flags))
+AD4- atomic+AF8-inc(+ACY-lo-+AD4-plh+AF8-refcount)+ADs-
+AD4- +AH0-
Thank for spotting this+ACE- Applying to the bugfixes branch...

Trond Myklebust
Linux NFS client maintainer

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at