[PATCH 2/2] cgroups: fix cgroup_event_listener error handling

From: Greg Thelen
Date: Fri Jan 04 2013 - 16:28:52 EST

If the <absolute-path-to-control-file> command line parameter cannot
be opened, then cgroup_event_listener prints an error message and
tries to return an error. However, due to an uninitialized variable
the return value was undefined.

With this patch such failures always return non-zero error.

Compiler warning found this:
$ gcc -Wall -O2 cgroup_event_listener.c
cgroup_event_listener.c: In function âmainâ:
cgroup_event_listener.c:109:2: warning: âretâ may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>
tools/cgroup/cgroup_event_listener.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/cgroup/cgroup_event_listener.c b/tools/cgroup/cgroup_event_listener.c
index 3e082f9..a70f00c 100644
--- a/tools/cgroup/cgroup_event_listener.c
+++ b/tools/cgroup/cgroup_event_listener.c
@@ -35,7 +35,7 @@ int main(int argc, char **argv)
if (cfd == -1) {
fprintf(stderr, "Cannot open %s: %s\n", argv[1],
- goto out;
+ return 1;

ret = snprintf(event_control_path, PATH_MAX, "%s/cgroup.event_control",

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/