Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown

From: David Miller
Date: Fri Jan 04 2013 - 18:20:24 EST

From: Lubomir Rintel <lkundrak@xxxxx>
Date: Fri, 4 Jan 2013 15:17:43 +0100

> @@ -943,7 +943,7 @@ static int txq_reclaim(struct tx_queue *txq, int budget, int force)
> struct netdev_queue *nq = netdev_get_tx_queue(mp->dev, txq->index);
> int reclaimed;
> - __netif_tx_lock(nq, smp_processor_id());
> + __netif_tx_lock_bh(nq);

I still don't understand why this change is necessary.

The TX reclaim function is invoked in software interrupt context in
all of the places where this lockdep warning might matter.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at