Re: [PATCH v7u1 01/31] x86, mm: Fix page table early allocationoffset checking
From: Borislav Petkov
Date: Sat Jan 05 2013 - 08:05:23 EST
On Fri, Jan 04, 2013 at 01:50:18PM -0800, Yinghai Lu wrote:
> On Thu, Jan 3, 2013 at 11:17 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > On Thu, Jan 03, 2013 at 04:48:21PM -0800, Yinghai Lu wrote:
> >> During debugging loading kernel above 4G, found one page if is not used
> >> in BRK with early page allocation.
> >> pgt_buf_top is address that can not be used, so should check if that new
> >> end is above that top, otherwise last page will not be used.
> >> Fix that checking and also add print out for every allocation from BRK.
> > This commit message still bothers the hell out of me. Please, fix it up
> > to something more readable like the below, for example:
> > "pgt_buf_top is an address which cannot be used so we should check
> > whether the new 'end' is above it. Otherwise, the last BRK page remains
> > unused.
> > Fix that check and add a debug printout of every BRK allocation."
> but your changelog is wrong.
> it is NOT last BRK page.
"...otherwise last page will not be used." ??? Is it the current last
page? Which is it?
The fact that I need ot ask twice and cannot simply read it out from
your commit message should tell you one thing and one thing only: you
need to write out in more detail what you're doing so that people can
understand it. I admit, I'm not the smartest but that's even better -
you need to explain your code even to dumb people :-).
> it is NOT every BRK allocation.
Ok, so it is not every BRK allocation but it is for "every allocation
from BRK." But why do we need to print it out then? Why is it important
to print out every PGTABLE allocation we do from BRK? The answer to
*that* question should definitely go into the commit message.
So I hope you can catch my drift: this code needs very good explanation
because no one can take a look into your brain and read it out from
there. So please, let's give that commit message another try.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/