Re: [PATCH] dma: tegra: add support for Tegra114 SoC

From: Laxman Dewangan
Date: Sun Jan 06 2013 - 10:57:49 EST


On Sunday 06 January 2013 08:07 PM, Vinod Koul wrote:
On Sat, Jan 05, 2013 at 05:36:08PM +0530, Laxman Dewangan wrote:
NVIDIA's Tegra114 has APB DMA controller which supports channel wise
pause control. The global pause is used for clock gating and hence
DMA registers are not accessible if DMAs are globally disabled.

Add support for use of channel wise pause feature for Tegra114 SOCs.
Looks fine to me. Only issue being that changelog tells me you are adding
support for 114, but patch seems more of adding pause support and while at it
also add entries for 114.
Care to update changelog & title...

The channel wise pause come along with T114 and that's why it is together in this change.
Probably I need to split the change into two patches: One for adding feature of channel wise pause and other for adding support of T114.
This way it will not mixup the stuff and will much clear about change.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/