Re: [PATCH] drivers/net/wireless/mwl8k.c: avoid use-after-free

From: Nickolai Zeldovich
Date: Sun Jan 06 2013 - 22:02:25 EST

On Sun, Jan 6, 2013 at 9:48 PM, Lennert Buytenhek
<buytenh@xxxxxxxxxxxxxx> wrote:
> Good catch, but the patch would be better titled "mwl8k.c: avoid
> having a working driver", as the station_id return code _is_ needed
> by the caller in case of success.

I'm not quite sure what you mean -- is there something subtle going on
here? I believe my patch preserves the semantics of the original
code: it returns the value of p->station_id if mwl8k_post_cmd()
returned 0, but it just does so by reading p->station_id first before
calling kfree(cmd).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at