Re: [PATCH] drivers/power/88pm860x_battery.c: eliminate possiblereferences to released resources
From: Dan Carpenter
Date: Mon Jan 07 2013 - 02:09:51 EST
On Sun, Jan 06, 2013 at 10:53:21PM -0800, Anton Vorontsov wrote:
> On Mon, Jan 07, 2013 at 09:42:23AM +0300, Dan Carpenter wrote:
> > On Sun, Jan 06, 2013 at 01:16:50PM -0800, Anton Vorontsov wrote:
> > > The patch is whitespace-damaged (for some reason there are two spaces in
> > > the beginning of each non-change line). I repeated changes manually, but
> > > you might want to fix your mail/patch setup anyway. :)
> > >
> > It may be something on your end, the patch applies fine for me.
> I just looked into Julia's email headers, and it says:
> Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
> flowed? for the patch? :) That's not right.
> Documentation/email-clients.txt says:
> Don't send patches with "format=flowed". This can cause unexpected
> and unwanted line breaks.
> As for why it applied fine for you, your mailer probably automatically
> decodes the content, but I apply mbox file directly. (If I '<ESC>-C' the
> email in mutt, then it also applies for me, but I normally don't do that.)
Ah. You're right, of course. I'm also using mutt but I have
<decode-copy> in my macros like you say.
macro index,pager ap "<shell-escape>rm -f tmp/patch<enter><decode-copy>tmp/patch<enter><shell-escape>~/progs/kernel/apply_patch.sh ~/var/mail/tmp/patch<enter>"
When I pipe to scripts it uses the undecoded copy. I wish I knew
how to use the decoded version there as well...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/