Re: Fix test relying in wrong behavior of is_printable
From: Pantelis Antoniou
Date: Mon Jan 07 2013 - 04:55:25 EST
I can rework and resubmit to remove the comment, but the test doesn't fail:
> $ make check | grep 'MyBoardName.*-t s.*compatible'
> fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s label01.dts.fdtget.test.dtb / compatible: PASS
As of today's pull.
On Jan 7, 2013, at 12:14 AM, Jon Loeliger wrote:
>> Hi David
>> =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85
>> 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson <david@xxxxxxxxx=
>> opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5:
>>> On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
>>>> After fixing the is_printable bug the test suite fails.
>>>> Fix it with this patch
>>>> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>
>>> Rather than just removing the test, it would be better to still run it
>>> using an explicit -t bi to force the byte output.
>> Perhaps it wasn't exactly clear in the patch. The old test case output is co=
>> mmented out but there is test case output for the new patch.=20
>> So the test is not removed.=20
> Uh, yeah, something needs to be done here still.
> (There is a failing test still.)
> Could we get a resubmission of the fix, please?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/