Re: [PATCH 0/8] DMA: COH901318 in-factoring of platform

[Vinod Koul]

On Sun, Jan 06, 2013 at 11:43:05PM +0100, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> This patch series moves the big, complex platform data for the U300
> DMA controller COH901318 down into the driver, rids the
> <mach/coh901318.h> header from the global scope, creates a proper
> platform data header for the few things we acually want to
> parametrize from the platform, and all in preparation for device
> tree support.
> 
> Vinod, it'd be great if you could ACK this so I can merge it
> through the ARM SoC tree. The driver is propably more maintainable
> in this shape as well without lots of pieces spread out all over
> the place.
Sure the change look fine and mostly seems to be code reorg and cleanup.
Perhpas the below diffstat could have helped in review if it showed file move

Acked-by: Vinod Koul <vinod.koul@xxxxxxxxx>
> 
> Linus Walleij (8):
>   dma: coh901318: create a proper platform data file
>   dma: coh901318: push platform data into driver
>   dma: coh901318: remove hardcoded target addresses
>   dma: coh901318: skip hard-coded addresses
>   dma: coh901318: push header down into the DMA subsystem
>   dma: coh901318: push definitions into driver
>   dma: coh901318: merge header files
>   dma: coh901318: cut down on platform data abstraction
> 
>  arch/arm/mach-u300/core.c                   | 1087 +---------------------
>  arch/arm/mach-u300/dma_channels.h           |   60 --
>  arch/arm/mach-u300/include/mach/coh901318.h |  267 ------
>  arch/arm/mach-u300/spi.c                    |    3 +-
>  drivers/dma/coh901318.c                     | 1302 ++++++++++++++++++++++++++-
>  drivers/dma/coh901318.h                     |  141 +++
>  drivers/dma/coh901318_lli.c                 |    4 +-
>  drivers/dma/coh901318_lli.h                 |  124 ---
>  include/linux/platform_data/dma-coh901318.h |   72 ++
>  9 files changed, 1469 insertions(+), 1591 deletions(-)
>  delete mode 100644 arch/arm/mach-u300/dma_channels.h
>  delete mode 100644 arch/arm/mach-u300/include/mach/coh901318.h
>  create mode 100644 drivers/dma/coh901318.h
>  delete mode 100644 drivers/dma/coh901318_lli.h
>  create mode 100644 include/linux/platform_data/dma-coh901318.h
> 
> -- 
> 1.7.11.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/