Re: [PATCH 1/5] capemgr: Beaglebone DT overlay based cape manager

From: Pantelis Antoniou
Date: Mon Jan 07 2013 - 15:26:27 EST


Hi Tony,

On Jan 7, 2013, at 10:23 PM, Tony Lindgren wrote:

> * Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> [130107 12:16]:
>> Hi Tony,
>>
>> On Jan 7, 2013, at 10:09 PM, Tony Lindgren wrote:
>>
>>> * Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> [130107 10:54]:
>>>> A cape loader based on DT overlays and DT objects.
>>>>
>>>> Beaglebone cape manager implementation.
>>>>
>>>> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>
>>>> ---
>>>> arch/arm/mach-omap2/Kconfig | 2 +
>>>> drivers/misc/Kconfig | 2 +
>>>> drivers/misc/Makefile | 1 +
>>>> drivers/misc/cape/Kconfig | 5 +
>>>> drivers/misc/cape/Makefile | 5 +
>>>> drivers/misc/cape/beaglebone/Kconfig | 11 +
>>>> drivers/misc/cape/beaglebone/Makefile | 5 +
>>>> drivers/misc/cape/beaglebone/capemgr.c | 1835 ++++++++++++++++++++++++++++++++
>>>
>>> The driver should probably be in drivers/bus?
>>>
>>
>> It was a bus on the previous iteration and there was a flame storm of epic proportions.
>
> Heh :)
>
>> It is not a bus at all now, it's just a device loader; there are no
>> bus constructs at all. I am at a loss to classify it really, so drivers/misc
>> where every misfit ends up sounded OK.
>
> Right..
>
>> I'm open to suggestions though.
>
> Well how about split it to an eeprom driver, and Linux generic
> device loader parts?
>

All that's left is the eeprom driver (accessor) and calls to the
generic DT overlay constructs.

If you caught on the previous patchset about DT overlays it should be
clear.

So it is split along those lines already.


> Regards,
>
> Tony

Regards

-- Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/