RE: [PATCH 2/2] Staging: comedi: addi_common.h: fixes

From: H Hartley Sweeten
Date: Mon Jan 07 2013 - 17:50:53 EST

On Monday, January 07, 2013 3:40 PM, Greg KH wrote:
> On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote:
>> Reduced line lengths to 80 chars by removing extra spaces.
>> Signed-off-by: Lijo Antony <lijo.kernel@xxxxxxxxx>
>> ---
>> .../staging/comedi/drivers/addi-data/addi_common.h | 20 ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)


> As you didn't do this for all fields in the structure, it's not really
> worth doing it for just these, right?
> The proper thing to do is use kerneldoc format and document it all at
> the top of the structure, care to do that instead?

Hopefully I will soon get the rest of the addi-data drivers split off of the
addi_common stuff. This will effectively remove this header file so I'm
not sure it's worth making patches against it.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at