RE: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support

[Yang, Wenyou]

> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> Sent: 2013年1月7日 10:10
> To: Yang, Wenyou
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Ferre,
> Nicolas; plagnioj@xxxxxxxxxxxx; richard.genoud@xxxxxxxxx; Lin, JM;
> grant.likely@xxxxxxxxxxxx; spi-devel-general@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support
> 
> On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote:
> > From: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> []
> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> []
> > +static inline bool atmel_spi_use_dma(struct atmel_spi *as,
> > +				struct spi_transfer *xfer)
> > +{
> > +	if ((as->use_dma) && (xfer->len >= DMA_MIN_BYTES))
> > +		return true;
> > +	else
> > +		return false;
> > +}
> 
> Same unnecessary form.
> 
> 	return as->use_dma && xfer->len >= DMA_MIN_BYTES;
> 
> > +static inline bool atmel_spi_use_pdc(struct atmel_spi *as)
> > +{
> > +	if (as->use_pdc)
> > +		return true;
> > +	else
> > +		return false;
> > +}
> 
> Does this function really need to exist at all?
> 
Thanks a lot for your advice.

㈤旃??????+-遍荻?w??笔???dz罐??骅w*jg??????/??罐????璀??摺?囤??????:+v???佶>W?贽i?xPj???-?+?d?