Re: Fix test relying in wrong behavior of is_printable

[David Gibson]

On Sun, Jan 06, 2013 at 01:41:56PM +0200, Pantelis Antoniou wrote:
> Hi David
> 
> ÎÏÏ ÏÎ iPhone ÎÎÏ
> 
> 6 ÎÎÎ 2013, 5:58, Î/Î David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> ÎÎÏÎÏÎ:
> 
> > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> >> After fixing the is_printable bug the test suite fails.
> >> Fix it with this patch
> >> 
> >> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>
> > 
> > Rather than just removing the test, it would be better to still run it
> > using an explicit -t bi to force the byte output.
> 
> Perhaps it wasn't exactly clear in the patch. The old test case
> output is commented out but there is test case output for the new
> patch.

I realise that, but that's not my point.  Rather than replacing the
test for the old behaviour with the new one, I'd prefer to keep the
one checking the old behaviour, forcing that behaviour from fdtget
using -t bi

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: Digital signature