Re: add Packet hub driver for Topcliff Platform controller hub

[Arnd Bergmann]

On Tuesday 08 January 2013, Dan Carpenter wrote:
> On Tue, Jan 08, 2013 at 10:49:14AM +0000, Arnd Bergmann wrote:
> > On Monday 07 January 2013, Dan Carpenter wrote:
> > > Sorry my question is about an old patch.  Smatch complains because we
> > > only pass a PAGE_SIZE buffer to sysfs files so the test for
> > > "if (count > PCH_PHUB_OROM_SIZE) {" makes it think we are overflowing.
> > > In fact, count is never more than 4096 so there is no overflow, but I
> > > also think that it means only the first 4096 bytes of the firmware gets
> > > updated.
> > 
> > I think it works correctly as long as user space keeps writing into the
> > bin file when getting short write return (4096 bytes).
> > 
> 
> Ah.  Ok.  I misunderstood.  I've looked through it again and you're
> right.
> 
> Sorry for the noise.

No worries, the report looked totally plausible and I also had to look
up how bin files work.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/