Re: [PATCH 02/25] ab8500_charger: don't use [delayed_]work_pending()

From: Linus Walleij
Date: Tue Jan 08 2013 - 09:30:10 EST


On Sat, Dec 22, 2012 at 2:56 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:

> There's no need to test whether a (delayed) work item in pending
> before queueing, flushing or cancelling it. Most uses are unnecessary
> and quite a few of them are buggy.
>
> Remove unnecessary pending tests from ab8500_charger. Only compile
> tested.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Srinidhi Kasagar <srinidhi.kasagar@xxxxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>

Works like a charm for us, thanks!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Tested-by: Marcus Cooper <marcus.xm.cooper@xxxxxxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/