Re: [PATCH v5 00/12] x86/microcode: Early load microcode

[H. Peter Anvin]

On 01/08/2013 12:04 PM, Konrad Rzeszutek Wilk wrote:
>>
>> Why is this code invoked on Xen at all?  That seems crazy.
> 
>  [PATCH v4 09/11] x86/head64.c: Early update ucode in 64-bit
> 
> has this in x86_64_start_kernel:
> 
> ..
>         load_idt((const struct desc_ptr *)&idt_descr);
> 
> +       /*
> +        * Load microcode early on BSP.
> +        */
> +       load_ucode_bsp(__va(real_mode_data));
> +
>         copy_bootdata(__va(real_mode_data));
> 
> Which gets called after xen_start_kernel has setup pagetables,
> bootparams, etc ready for the generic code to be invoked.
> 
> Or am I looking at an old version of these patches.

We really shouldn't do that in that flow.  This doesn't make sense on
non-native.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/