Re: [3.6.9 -> 3.7.1 regression] sound: snd_hda_intel codec probing issue?

From: Takashi Iwai
Date: Wed Jan 09 2013 - 05:00:16 EST


At Tue, 08 Jan 2013 21:25:21 +0100,
Vincent Blut wrote:
>
> Le mardi 08 janvier 2013 Ã 13:56 +0100, Takashi Iwai a Ãcrit :
> > At Tue, 08 Jan 2013 13:28:55 +0100,
> > From: Takashi Iwai <tiwai@xxxxxxx>
> > Subject: [PATCH] ALSA: hda - Disable runtime D3 for Intel CPT & co
> >
> > We've got a few bug reports that the runtime D3 results in the dead
> > HD-audio controller. It seems that the problem is in a deeper level
> > than the sound driver itself, so as a temporal solution, disable the
> > feature for these controllers again.
> >
> > Reported-by: Vincent Blut <vincent.debian@xxxxxxx>
> > Reported-by: Maurizio Avogadro <mavoga@xxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx> [v3.7]
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > ---
> > sound/pci/hda/hda_intel.c | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index cca8727..0b6aeba 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -573,9 +573,12 @@ enum {
> > #define AZX_DCAPS_PM_RUNTIME (1 << 26) /* runtime PM support */
> >
> > /* quirks for Intel PCH */
> > -#define AZX_DCAPS_INTEL_PCH \
> > +#define AZX_DCAPS_INTEL_PCH_NOPM \
> > (AZX_DCAPS_SCH_SNOOP | AZX_DCAPS_BUFSIZE | \
> > - AZX_DCAPS_COUNT_LPIB_DELAY | AZX_DCAPS_PM_RUNTIME)
> > + AZX_DCAPS_COUNT_LPIB_DELAY)
> > +
> > +#define AZX_DCAPS_INTEL_PCH \
> > + (AZX_DCAPS_INTEL_PCH_NOPM | AZX_DCAPS_PM_RUNTIME)
> >
> > /* quirks for ATI SB / AMD Hudson */
> > #define AZX_DCAPS_PRESET_ATI_SB \
> > @@ -3586,13 +3589,13 @@ static void azx_remove(struct pci_dev *pci)
> > static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
> > /* CPT */
> > { PCI_DEVICE(0x8086, 0x1c20),
> > - .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> > + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> > /* PBG */
> > { PCI_DEVICE(0x8086, 0x1d20),
> > - .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> > + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> > /* Panther Point */
> > { PCI_DEVICE(0x8086, 0x1e20),
> > - .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> > + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> > /* Lynx Point */
> > { PCI_DEVICE(0x8086, 0x8c20),
> > .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
>
> Well, my sound controller behaves nicely with the above quirk.
>
> Tested-by: Vincent Blut <vincent.debian@xxxxxxx>

OK, I queued the patch now.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/