Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger

From: Arnd Bergmann
Date: Wed Jan 09 2013 - 05:18:59 EST


On Wednesday 09 January 2013, Lee Jones wrote:
> diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig
> index 5dea906..0f25b07 100644
> --- a/arch/arm/mach-ux500/Kconfig
> +++ b/arch/arm/mach-ux500/Kconfig
> @@ -43,6 +43,8 @@ config MACH_HREFV60
> config MACH_SNOWBALL
> bool "U8500 Snowball platform"
> select MACH_MOP500
> + select LEDS_TRIGGERS
> + select LEDS_TRIGGER_HEARTBEAT
> help
> Include support for the snowball development platform.

Be careful with "select" statements like this when there are other
dependencies. I think LEDS_TRIGGERS depends on LEDS_CLASS, so this
should probably be written as

select LEDS_TRIGGERS if LEDS_CLASS

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/