Re: sd8688 firmware location

From: Dan Williams
Date: Wed Jan 09 2013 - 17:42:40 EST


On Wed, 2013-01-09 at 00:56 +0100, Lubomir Rintel wrote:
> Hi!
>
> btmrvl_sdio and libertas_sdio both use firmware files sd8688.bin and
> sd8688_helper.bin. In linux-firmware, they're present in libertas/ tree and
> (since 3d32a58b) libertas_sdio perfers loading it from there, while it is able
> to fallback to load it from linux-firmware root. btmrvl_sdio, on the other hand
> only looks in the root and ends up not being successful.
>
> Obviously, there are two solutions to the problem -- either teach btmrvl_sdio
> to look into libertas/, or move the files in linux-firmware tree. I don't
> really have a strong preference, though it probably makes less sense to keep in
> in libertas/, since the bluetooth hardware is not really marketed as "Libertas."
>
> I'm following up with patches to linux and linux-firmware and I'd be very
> thankful if you could pick one (not both of them).

So the BT part and the wifi part have different SDIO IDs; are they
actually connected separately to the SDIO bus? Or is the chip only in
one mode at one time or something like that? Is there a problem with
having both libertas and btmrvl loaded at the same time since they're
essentially the same chip?

I don't really mind moving stuff to mrvl/ out of libertas/ for these
devices, but I do want some backwards compat code in libertas for that.
Unless, of course, Marcel was talking about symlinks in the
linux-firmware git tree, which would be fine with me. The important
point is that simply updating your linux-firmware package or install or
whatever *should not* result in a failed firmware load.

Dan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/