Re: [PATCH v6 04/15] memory-hotplug: remove /sys/firmware/memmap/Xsysfs

[Tang Chen]

Hi Andrew,

On 01/10/2013 06:49 AM, Andrew Morton wrote:
> On Wed, 9 Jan 2013 17:32:28 +0800
> Tang Chen<tangchen@xxxxxxxxxxxxxx>  wrote:
>
> > When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type}
> > sysfs files are created. But there is no code to remove these files. The patch
> > implements the function to remove them.
> >
> > Note: The code does not free firmware_map_entry which is allocated by bootmem.
> >        So the patch makes memory leak. But I think the memory leak size is
> >        very samll. And it does not affect the system.
>
> Well that's bad.  Can we remember the address of that memory and then
> reuse the storage if/when the memory is re-added?  That at least puts an upper
> bound on the leak.

I think we can do this. I'll post a new patch to do so.

Thanks. :)

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/