Re: [PATCH 09/14] ARM: tegra: Move pmc.h to include/mach

From: Thierry Reding
Date: Thu Jan 10 2013 - 23:08:34 EST


On Thu, Jan 10, 2013 at 05:15:07PM -0700, Stephen Warren wrote:
> On 01/09/2013 01:43 PM, Thierry Reding wrote:
> > In preparation for moving the PCIe driver into the drivers/pci/host
> > directory, this header, which contains prototypes that are required by
> > the PCIe driver, needs to be moved to a globally visible location.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> > ---
> > Note that eventually the code in pmc.c and powergate.c should probably
> > be split out into a separate driver. The PMC registers are also directly
> > accessed from tegra20_clocks.c and tegra30_clocks.c, so that it might be
> > required to provide that functionality through the new driver as well.
> > ---
> > arch/arm/mach-tegra/common.c | 2 +-
> > arch/arm/mach-tegra/include/mach/pmc.h | 24 ++++++++++++++++++++++++
> > arch/arm/mach-tegra/pmc.h | 24 ------------------------
>
> On IRC, we'd talked about putting the public functionality in
> include/linux/tegra-pmc.h so that we wouldn't add to include/mach, which
> would make it harder to make Tegra support ARM multi-platform. Perhaps
> that IRC discussion happened after you posted this series?

I'm not sure, it's equally possible that I just forgot. Will fix it up.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature