Re: 3.7.X vs 3.6.11 HP Folio 9470m brightness regression?

From: Fabio Coatti
Date: Mon Jan 14 2013 - 03:13:24 EST


While looking at a different issue (rfkill), related to this commit:
====
> a57f7f9175b8ccbc9df83ac13860488913115de4 is the first bad commit
> commit a57f7f9175b8ccbc9df83ac13860488913115de4
> Author: Bob Moore <robert.moore@xxxxxxxxx>
> Date: Fri Aug 17 10:55:02 2012 +0800
>
> ACPICA: Add Windows8/Server2012 string for _OSI method.
> This change adds a new _OSI string, "Windows 2012" for both Windows 8
> and Windows Server 2012.
> >From Microsoft document "How to Identify the Windows Version in ACPI
> by Using _OSI", July 13, 2012.
>
> Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> Signed-off-by: Feng Tang <feng.tang@xxxxxxxxx>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
====

I discovered that reverting this commit (or, as suggested by joeyli
<jlee@xxxxxxxx>, booting with acpi_osi="!Windows 2012" ) also fixes
the brightness issue. So it seems related to the same ACPI issue, now
I wonder how it's happened that I got the wrong commit while
bisecting. Sorry for the noise, now the issue is still there but makes
more sense ):)



2013/1/12 Fabio Coatti <fabio.coatti@xxxxxxxxx>:
> well, I tried to do that, bisecting between 3.6.10 and 3.7. I'm not
> sure to have done that properly, as the result seems quite harmless,
> however here it is:
>
> d978348b300595b067b80980f6a78db09fcd584c is the first bad commit
> commit d978348b300595b067b80980f6a78db09fcd584c
> Author: Bob Moore <robert.moore@xxxxxxxxx>
> Date: Fri Aug 17 10:51:47 2012 +0800
>
> ACPICA: Split ACPICA initialization functions to new file, utxfinit.c
>
> Split utxface.c to improve modularity and reduce file size.
>
> Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> Signed-off-by: Feng Tang <feng.tang@xxxxxxxxx>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
>
> :040000 040000 57bc8451026afe02fdbc2970b152164ff4e5412a
> 55311ce2f9fed66501b06f93f67fa99b54d46e86 M drivers
>
> Please let me know If I've done something wrong or if I can help in other ways.
>
> Many thanks for the hint.
>
>
> 2013/1/12 Daniel Vetter <daniel.vetter@xxxxxxxx>:
>> On Sat, Jan 12, 2013 at 12:22 PM, Fabio Coatti <fabio.coatti@xxxxxxxxx> wrote:
>>> I'm seeing the same behaviour on 3.7.2; even
>>> echo "NN" > brightness has no effect.
>>> I've tried to look at changes between 3.6.11 and 3.7.2 but probably
>>> this is beyond my skills ;)
>>
>> If the regression is with the acpi_video backlight, then it's very
>> likely not a bug in drm/i915. Quickest way to figure that out is to do
>> a git bisect between 3.6 and 3.7, my favourite howto is:
>> http://www.reactivated.net/weblog/archives/2006/01/using-git-bisect-to-find-buggy-kernel-patches/
>>
>> Cheers, Daniel
>>
>>> 2012/12/20 Fabio Coatti <fabio.coatti@xxxxxxxxx>:
>>>> In data mercoledì 19 dicembre 2012 17:10:29, hai scritto:
>>>>> ----- Original Message -----
>>>>>
>>>>> > From: "Fabio Coatti" <fabio.coatti@xxxxxxxxx>
>>>>> > To: linux-kernel@xxxxxxxxxxxxxxx
>>>>> > Sent: Wednesday, 19 December, 2012 5:01:30 PM
>>>>> > Subject: 3.7.X vs 3.6.11 HP Folio 9470m brightness regression?
>>>>> >
>>>>> > Hi,
>>>>> > I'm testing kernels 3.7.X vs 3.6.11 on an HP Folio 9470m machine,
>>>>> > i915
>>>>> > driver for a VGA compatible controller: Intel Corporation 3rd Gen
>>>>> > Core
>>>>> > processor Graphics Controller (rev 09) 8086:0166
>>>>> >
>>>>> > With 3.6.11, the brightness can be correctly set using fn+f9/10: kde
>>>>> > shows the bar and brightness changes.
>>>>> >
>>>>> > With 3.7.1 kde shows the percentage bar and
>>>>> > /sys/class/backlight/acpi_video0/brightness is updated, but the
>>>>> > screen
>>>>> > brightness does not changes.
>>>>>
>>>>> I had a similar problem with my Dell laptop and i915/acpi...
>>>>>
>>>>> Is there another acpi_video? device? In my case two showed up in 3.7
>>>>> whereas in 3.6 there was one. In 3.7 it was controlling the wrong one
>>>>> apparently.
>>>>
>>>> Well, this seems not to be the case, I have only one acpi_video:
>>>>
>>>> calvin ~ # ls -l /sys/class/backlight/
>>>> totale 0
>>>> lrwxrwxrwx 1 root root 0 20 dic 09.20 acpi_video0 ->
>>>> ../../devices/pci0000:00/0000:00:02.0/backlight/acpi_video0
>>>>
>>>> calvin ~ # ls -l /sys/devices/pci0000:00/0000:00:02.0/backlight
>>>> totale 0
>>>> drwxr-xr-x 3 root root 0 20 dic 09.20 acpi_video0
>>>>
>>>>
>>>>
>>>> --
>>>> Fabio
>>>
>>>
>>>
>>> --
>>> Fabio
>>
>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>
>
>
> --
> Fabio



--
Fabio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/