Re: [PATCH] spi: erase pointer to drvdata on removal

From: Grant Likely
Date: Mon Jan 14 2013 - 15:11:19 EST


On Mon, 14 Jan 2013 02:51:45 +0000, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote:
> > As for i2c-core, let the SPI core handle the removal of the device's
> > drvdata, after a remove() or a probe() failure.
>
> Any driver that notices this change is buggy, the driver shouldn't
> use a drvdata value that it didn't set. I had thought this stuff had
> all been removed from I2C and either dropped or factored out into the
> driver core...

Looks to me like __device_release_driver() in drivers/base/dd.c already
does this.

g.


--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/