Re: [PATCHv2 1/4] clockevents: Add generic timer broadcastreceiver

From: Thomas Gleixner
Date: Tue Jan 15 2013 - 06:24:41 EST


On Mon, 14 Jan 2013, Mark Rutland wrote:
> On Mon, Jan 14, 2013 at 02:17:26PM +0000, Thomas Gleixner wrote:
> > > I thought this previously also [1], but I couldn't find any path such that a
> > > tick_cpu_device would have an evtdev without an event_handler. We always set the
> > > handler before setting evtdev, and alway wipe evtdev before wiping the handler.
> > >
> > > Have I missed something?
> >
> > That's an x86 specific issue. Though we could try and make that
> > functionality completely generic.
>
> Just to check: is the evt->event_handler check necessary?

For x86 yes. See the comment.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/