Re: [PATCH] tools lib traceevent: Fix warning on '>=' operator

From: Steven Rostedt
Date: Tue Jan 15 2013 - 08:45:45 EST


On Tue, 2013-01-15 at 17:02 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> Although the '>=' (and '<=') operator is handled properly in
> libtraceevent, it emitted following spurious warnings on perf test:
>
> $ perf test
> 5: parse events tests :
> ...
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> Warning: unknown op '>='
> ...
>
> Add the operator to the checks.
>

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
> tools/lib/traceevent/event-parse.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index 5a824e355d04..7286f0e82c29 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -1785,6 +1785,8 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok)
> strcmp(token, "/") == 0 ||
> strcmp(token, "<") == 0 ||
> strcmp(token, ">") == 0 ||
> + strcmp(token, "<=") == 0 ||
> + strcmp(token, ">=") == 0 ||
> strcmp(token, "==") == 0 ||
> strcmp(token, "!=") == 0) {
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/