Re: [PATCH 07/13] perf hist browser: Add support for event group view

[Namhyung Kim]

On Tue, 15 Jan 2013 15:32:26 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 15, 2013 at 04:31:51PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>> 
>> Show group members' overhead also when showing the leader's if event
>> group is enabled.  Use macro for defining hpp functions which looks
>> almost identical.
>> 
>> Also move coloring logic into the hpp function so that each value can
>> be colored independently.
>
> Just from reading the description: when we have this "Also do this extra
> thing" it smells like we need to break the patch in two... Can this be
> done?

Sure.  I'll break it.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/