Re: [PATCH 00/10] TTY: switch flipping functions to tty_port

[Steven Rostedt]

On Wed, 2013-01-16 at 16:59 +0100, Jiri Slaby wrote:
> On 01/16/2013 04:44 PM, Steven Rostedt wrote:
> > On Wed, 2013-01-16 at 14:37 +0100, Jiri Slaby wrote:
> >> Steven, do you have any plans with the driver? What is its planned destiny?
> > 
> > Well, I'm currently using the device in my main machine. As it is my
> > main box, I don't update the kernel as often.
> > 
> > Let me know what I need to do to fix it in the current kernel.
> 
> Every port in the system has to have its struct tty_port counterpart.
> 
> /me looked into the code
> 
> OMG. It contains a true copy of serial_core!

LOL... Yes this driver truly does suck. I started with a copy that came
with the device (well, downloaded it from their web site). I did the
bare minimum to get it working with the latest kernel, in the hope that
I can get others to help make it into a proper driver.

> 
> In the beginning (to remove the BROKEN flag), what it needs is struct
> tty_port to be added to struct sb_uart_info. It obviously needs
> tty_port_init + tty_port_destroy at appropriate places. Then it needs
> tty_register_device to be switched to tty_port_register_device.
> 
> Finally, having the tty_port, all tty flipping functions take the
> tty_port, not tty_struct (the build errors reported). This is easy while
> you have a tty_port.
> 
> In the long term, it needs to get rid of the all the pseudo-uart* stuff
> (the copy of serial_core) and use only tty layer+tty_port helpers.

grumble, this is a bit more work than I currently have time for. This
driver needs some major loving. But my heart is someplace else, and
until I can get a divorce from what I'm currently working on, this
driver will need to find lovers from someone else.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/