Re: [PATCH 06/10] goldfish: emulated MMC device

[Felipe Balbi]

Hi,

On Wed, Jan 16, 2013 at 04:59:38PM +0000, Alan Cox wrote:
> +#define OMAP_MMC_CMDTYPE_BC	0
> +#define OMAP_MMC_CMDTYPE_BCR	1
> +#define OMAP_MMC_CMDTYPE_AC	2
> +#define OMAP_MMC_CMDTYPE_ADTC	3

OMAP ?? :-) If you guys are emulating an OMAP mmc controller, why don't
you just re-use the omap mmc driver instead of duplicating the code ?

same comments about devm_* and the GPL license

-- 
balbi

Attachment: signature.asc
Description: Digital signature