Re: [[PATCH v2]] OMAP: omap4-panda: add WiLink shared transportpower functions

From: Tony Lindgren
Date: Thu Jan 17 2013 - 12:31:22 EST


* Peter Ujfalusi <peter.ujfalusi@xxxxxx> [130117 02:44]:
> On 01/17/2013 11:35 AM, Luciano Coelho wrote:
> > This out-of-tree code doesn't explain why we need to do the
> > enable/disable in the board file. We just need to do things a bit
> > differently in the driver. I'll start cleaning all this stuff up for
> > -next pretty soon.
> >
> > For now, ie. 3.7 (stable) and 3.8, do we agree in taking this patch so
> > that TI-ST at least works on Panda? Simply reverting the gpio removal
> > patch doesn't help, because we also need to handle the UART2 muxing
> > (which my patch does as well).
>
> I don't see better way to fix this either. In any case, I give you my:
>
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

So what is actually broken? The horrible bluetooth muxing over serial
port? If so, let's rather fix it properly than even attempt to fix
it as it seems that it's been broken for two merge windows now.

Also, let's just do absolutely minimal board-*.c file fixes now.
This thing should be just moved to use DT so we can flip over omap4
to be DT only and drop estimated 5k LOC from mach-omap2.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/