Re: [RFC][PATCH] slub: Keep page and object in sync inslab_alloc_node()

From: Steven Rostedt
Date: Thu Jan 17 2013 - 19:23:09 EST


On Thu, 2013-01-17 at 18:20 -0500, Steven Rostedt wrote:
> object = c->freelist;
> page = c->page;

Hmm, having local_irq_restore() here is probably just as good, as object
and page were grabbed together under it. It doesn't change the condition
below any.

/me updates patch.

-- Steve

> - if (unlikely(!object || !node_match(page, node)))
> +
> + new_object = !object || !node_match(page, node);
> + local_irq_restore(flags);
> +
> + if (new_object)
> object = __slab_alloc(s, gfpflags, node, addr, c);
>
> else {
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/