Re: [PATCH 2/3] workqueue, async: implement work/async_current_func()

From: Tejun Heo
Date: Thu Jan 17 2013 - 22:04:00 EST


On Thu, Jan 17, 2013 at 06:59:36PM -0800, Tejun Heo wrote:
> I'd prefer to keep struct worker inside workqueue.c, so how about
> keeping the workqueue part and make async part current_is_async()?

Another thing is that it seems like having introspection type
interface often lead to abuses - work_pending(), work_busy() both
ended up bringing more unnecessary dependencies and subtle bugginess
on internal details than actual benefits. Querying %current is much
less likely to be harmful in itself but I'm afraid it might encourage
its users to develop something crazy on top. It might be a good idea
to make it only available to async.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/