Re: [[PATCH v2]] OMAP: omap4-panda: add WiLink shared transportpower functions

[Luciano Coelho]

On Thu, 2013-01-17 at 15:16 -0800, Tony Lindgren wrote:
> * Luciano Coelho <coelho@xxxxxx> [130117 10:04]:
> > But this patch is pretty small and simple, so why not include it to at
> > least fix the breakage in 3.7 and 3.8? Whether you take it or not now
> > won't make any difference in the 5k LOC in these kernel versions.
> 
> Well we are planning to drop the non-DT support for omap4 as soon as it's
> usable with DT. For omap4 we are only carrying SDP and panda support to
> make this transition easier. The only bindings missing AFAIK are wl12xx and
> USB.

In my view this is a regression and it should be fixed with as simple a
patch as possible.  The alternative to my solution is to revert the
patch that removed the enable/disable from the ti-st driver *and* fix
u-boot, because if it doesn't mux the UART2 pins properly (and it
doesn't) the shared transport still won't work.


> If we add this, then it implies we're somehow supporting it, which is not
> the way to go IMHO as we need to get rid of these platform callbacks instead.

It's a regression fix, not a new feature.  I also think these callbacks
are silly, but it's the quickest solution I found for 3.7 and 3.8.


> What's your estimate of having minimal wl12xx WLAN DT binding available?

To tell you the truth, I haven't even started looking into DT for wl12xx
myself.  So I have no idea when it will be ready.  Benoit has been
looking into it, but I don't know how far he is.

--
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/