Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controllerand PHY

From: Felipe Balbi
Date: Fri Jan 18 2013 - 06:49:04 EST


On Thu, Jan 17, 2013 at 04:44:52PM +0530, kishon wrote:
> >>@@ -171,6 +188,11 @@ static inline void devm_usb_put_phy(struct device *dev, struct usb_phy *x)
> >> {
> >> }
> >>
> >>+static inline struct usb_phy_bind *usb_bind_phy(const char *dev_name, u8 index,
> >>+ const char *phy_dev_name)
> >>+{
> >>+ return NULL;
> >>+}
> >> #endif
> >>
> >> static inline int
> >>
> >
> >Controllers like ehci-omap which don't need OTG functionality would
> >benefit from this API. Can we make these PHY APIs not dependent on OTG /
> >OTG_UTILS?
>
> Actually much of whatever is in otg.c can be used by controllers
> which don't have OTG functionality (except otg_state_string). I
> vaguely remember, there was a patch that renamed otg.c to phy.c etc..
> I'm not sure what happened to that.

right, that has to be done eventually ;-)

--
balbi

Attachment: signature.asc
Description: Digital signature