Re: [PATCH 2/2] decompressors: make the default XZ_BCJ_* configmatch the selected architecture

From: Lasse Collin
Date: Fri Jan 18 2013 - 16:06:29 EST


On 2013-01-16 Florian Fainelli wrote:
> On 01/15/2013 07:11 PM, Lasse Collin wrote:
> > On 2013-01-15 Florian Fainelli wrote:
> >> config XZ_DEC_X86
> >> bool "x86 BCJ filter decoder" if EXPERT
> >> - default y
> >> + default y if X86
> >> select XZ_DEC_BCJ
> > [...]
> >
> > I think the "if EXPERT" strings should be dropped when all BCJ
> > filters aren't enabled by default. One should be able to enable all
> > filters without enabling EXPERT.
> Ok, this would probably be a third patch, since my two patches
> basically just modify what was already there, but I agree with you,
> even though EXPERT is enabled by default on most architectures and
> defconfigs. --

At least in x86_64_defconfig EXPERT isn't enabled. I'm fine with your
patches once also the "if EXPERT" strings are removed.

Acked-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>

--
Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/