Re: [PATCH] MODSIGN: Warn when module signature checking fails

From: Rusty Russell
Date: Sun Jan 20 2013 - 20:53:37 EST


Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> writes:

> Hi Rusty,
>
> On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>>
>> #ifdef CONFIG_MODULE_SIG
>> mod->sig_ok = info->sig_ok;
>> - if (!mod->sig_ok)
>> + if (!mod->sig_ok) {
>> + printk_once(KERN_NOTICE
>> + "%s: module verification failed: signature and/or"
>> + " required key missing - tainting kernel\n");
>
> Did you forget to add "mod->name"?

Indeed (turns back on CONFIG_MODULE_SIG).

Thanks,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/