Re: [PATCH] fat: eliminate iterations in fat_search_long in case of EOD

[OGAWA Hirofumi]

Namjae Jeon <linkinjeon@xxxxxxxxx> writes:

> 2013/1/20, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
>> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>>
>>> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>>>
>>> When searching a directory for names, we can stop checking for further
>>> entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The
>>> current code traverses the cluster chain of a directory until a hit is
>>> found or till the last cluster for that directory, ignoring the EOD mark.
>>> Fix this.
>>
>> f_pos still works fine after this change?
> Hi OGAWA.
> I can not find f_pos usage in fat_search_long function.
> Maybe, Have you seen other function such as __fat_readdir ?
> Let me know your opinion.

Ah, I see. Only ->lookup. So, this makes behavior more strange.
I.e. readdir() returns beyond 0, but lookup() can't find it?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/