Re: [PATCH 2/2] hwmon: (vexpress) Fix build error seen ifCONFIG_OF_DEVICE is not set

From: Pawel Moll
Date: Mon Jan 21 2013 - 10:19:54 EST


On Mon, 2012-12-31 at 08:13 +0000, Guenter Roeck wrote:
> Fix:
> vexpress.c: In function âvexpress_hwmon_name_showâ:
> vexpress.c:34:2: error: implicit declaration of function
> âof_get_propertyâ [-Werror=implicit-function-declaration]
> vexpress.c:34:27: warning: initialization makes pointer from integer
> without a cast [enabled by default]
> vexpress.c: In function âvexpress_hwmon_label_showâ:
> vexpress.c:43:22: warning: initialization makes pointer from integer
> without a cast [enabled by default]
>
> Seen if CONFIG_OF_DEVICE is not defined. of_get_property is declared in
> of.h which is only included by of_device.h if CONFIG_OF_DEVICE is defined.
> of.h needs to be included directly.
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Thanks, Guenter! (of course it's way too late for Acked-by: Pawel Moll
<pawel.moll@xxxxxxx>)

Pawel



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/