Re: [PATCH v2] mfd: tc3589x: use simple irqdomain

From: Linus Walleij
Date: Mon Jan 21 2013 - 16:43:54 EST


On Mon, Jan 14, 2013 at 11:28 PM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
> On Wed, Jan 2, 2013 at 2:40 PM, Linus Walleij
> <linus.walleij@xxxxxxxxxxxxxx> wrote:
>
>> This fixes a regression in the TC3589x driver introduced in
>> commit 15e27b1088245a2de3b7d09d39cd209212eb16af
>> "mfd: Provide the tc3589x with its own IRQ domain"
>>
>> If a system with a TC3589x expander is booted and a base
>> IRQ is passed from platform data, a legacy domain will
>> be used. However, since the Ux500 is now switched to use
>> SPARSE_IRQ, no descriptors get allocated on-the-fly,
>> and we get a crash.
>>
>> Fix this by switching to using the simple irqdomain that
>> will handle this uniformly and also allocates descriptors
>> explicitly.
>>
>> Also fix two small whitespace errors in the vicinity while
>> we're at it.
>>
>> Cc: stable@xxxxxxxxxx
>> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
>> ---
>> ChangeLog v1->v2:
>> - Update commit message after comments from Lee, add ACK, no
>> changes to the patche per se.
>
> Ping on this regression fix patch as well...

Ping on this!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/