Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource()

From: Thierry Reding
Date: Tue Jan 22 2013 - 11:16:05 EST


On Tue, Jan 22, 2013 at 08:08:09AM -0800, Greg Kroah-Hartman wrote:
> On Tue, Jan 22, 2013 at 11:25:59AM +0100, Thierry Reding wrote:
> > On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
> > > On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
> > > <thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
> > >
> > > > Convert all uses of devm_request_and_ioremap() to the newly introduced
> > > > devm_ioremap_resource() which provides more consistent error handling.
> > > >
> > > > devm_ioremap_resource() provides its own error messages so all explicit
> > > > error messages can be removed from the failure code paths.
> > > >
> > > > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> > > > Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> > > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > >
> > > Is the interface already in-kernel so I should apply this or is it
> > > added as part of this series so you're searching an ACK?
> >
> > It is part of this series, so your Acked-by would be great. Other
> > maintainers have done the same. Initially I had thought that it might be
> > easier if the patches went in through individual trees, but since the
> > first patch is a dependency, maybe it'd be better to take them all
> > through a single tree.
> >
> > Greg, any comments? Would you be willing to take the series through your
> > driver-core tree once all Acked-bys are there? Alternatively I guess we
> > could take the first patch into linux-next, at which point maintainers
> > could take this through the individual trees.
>
> Yes, I'll take the first patch through my driver-core tree, and add all
> of the patches that the subsystem maintainers have acked as well.
>
> As subsystem trees can't depend on linux-next, it makes it easier that
> way.

Most excellent. Thanks!

Thierry

Attachment: pgp00000.pgp
Description: PGP signature