Re: [PATCH 10/33] i2c: Convert to devm_ioremap_resource()

From: Wolfram Sang
Date: Tue Jan 22 2013 - 17:30:20 EST


On Mon, Jan 21, 2013 at 11:09:03AM +0100, Thierry Reding wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages so all explicit
> error messages can be removed from the failure code paths.
>
> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx

I still have the concerns I mentioned in the previous discussion but the
series seems to have enough momentum that we could also just try it.

So, for I2C:

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature