Re: USB: storage: optimize the matching rules and support new switchcommand for Huawei USB storage devices

[Greg KH]

On Wed, Jan 23, 2013 at 03:24:22AM +0000, Fangxiaozhi (Franko) wrote:
> Dear Greg:
> 
> > -----Original Message-----
> > From: Greg KH [mailto:greg@xxxxxxxxx]
> > Sent: Tuesday, January 22, 2013 11:04 PM
> > To: Fangxiaozhi (Franko)
> > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Xueguiying (Zihan);
> > Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@xxxxxx;
> > mdharm-usb@xxxxxxxxxxxxxxxxxx; sebastian@xxxxxxxxxxxxx
> > Subject: Re: USB: storage: optimize the matching rules and support new switch
> > command for Huawei USB storage devices
> > 
> > On Tue, Jan 22, 2013 at 09:16:08AM +0000, Fangxiaozhi (Franko) wrote:
> > > Dear Greg:
> > >
> > > 	OK, I have fixed up and resend the patches based on linux-3.8-rc4 today.
> > >
> > > 	Email subjects:
> > > 		1. [PATCH 1/2]linux-usb:define new macro and add new match rules
> > for Huawei USB storage devices
> > > 		2. [PATCH 2/2]linux-usb:define new macro and add new match rules
> > for
> > > Huawei USB storage devices
> > 
> > You sent me two patches, both with the same exact Subject: line.  That's not
> > ok, please be descriptive in the subject lines as to what each individual patch
> > does, as obviously they both don't do the same thing, right?
> 
> ----No, they do the same thing, so can I submit them in only one patch?

No they do not do the same thing, they both do different things.
Together, they do one thing, but you have to show the steps involved to
achieve that goal.

> ----(Last time, Sebastian thought that the one patch is too long, so
> he advised me to separate it into two patches).

He is correct, they need to be in two patches, but again, you can't call
them the same thing.

Please read the file, Documentation/SubmittingPatches for how to do this
properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/