Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource()

From: Linus Walleij
Date: Wed Jan 23 2013 - 03:36:23 EST


On Tue, Jan 22, 2013 at 11:25 AM, Thierry Reding
<thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
> On Tue, Jan 22, 2013 at 11:15:11AM +0100, Linus Walleij wrote:
>> On Mon, Jan 21, 2013 at 11:09 AM, Thierry Reding
>> <thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
>>
>> > Convert all uses of devm_request_and_ioremap() to the newly introduced
>> > devm_ioremap_resource() which provides more consistent error handling.
>> >
>> > devm_ioremap_resource() provides its own error messages so all explicit
>> > error messages can be removed from the failure code paths.
>> >
>> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
>> > Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
>> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>
>> Is the interface already in-kernel so I should apply this or is it
>> added as part of this series so you're searching an ACK?
>
> It is part of this series, so your Acked-by would be great.

Fair enough,
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/