Re: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

[Daniel Vetter]

On Wed, Jan 23, 2013 at 11:19:27AM +0800, Su, Xuemin wrote:
> From: xueminsu <xuemin.su@xxxxxxxxx>
> Date: Tue, 22 Jan 2013 22:39:39 +0800
> Subject: [PATCH] drm_crtc: check if fb_create return NULL
> 
> Some buggy driver may still return NULL in fb_create,
> which leads to kernel panic.
> 
> Signed-off-by: xueminsu <xuemin.su@xxxxxxxxx>

Imo just BUG_ON(!fb); and call it a day. Makes it pretty clear what's
expected of the drivers.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/