Re: [PATCH] clk: Add axi-clkgen driver

From: Lars-Peter Clausen
Date: Wed Jan 23 2013 - 05:48:10 EST


On 01/23/2013 11:27 AM, Russell King - ARM Linux wrote:
> On Wed, Jan 23, 2013 at 11:00:56AM +0100, Lars-Peter Clausen wrote:
>> I think I read somewhere at some point that ioread{8,16,32} is preferred
>> over write{b,h,l} in new code.
>
> But... there's *no* point using ioread*() if you don't only use the
> ioremap() interface.
>
> ioread*() is there to allow PC IO and PC MMIO accesses through one
> accessor depending on the cookie. ioremap() only ever returns cookies
> for MMIO accesses.

So your point is, if you know that it is MMIO memory only ever use readl and
friends?

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/