Re: [Update][PATCH] PCI: Document PCIE BUS MPS parameters

[Yijing Wang]

Hi Randy,
   Thanks for your review and comments! please refer to inlined comments below.

On 2013/1/24 7:39, Randy Dunlap wrote:
> On 01/23/13 04:28, Yijing Wang wrote:
>> Document PCIE BUS MPS parameters pcie_bus_tune_off, pcie_bus_safe,
>> pcie_bus_peer2peer, pcie_bus_perf into Documentation/kernel-parameters.txt.
>> These parameters were introduced by Jon Mason <mason@xxxxxxxx> at
>> commit 5f39e6705 and commit b03e7495a8. Document these into
>> kernel-parameters.txt can help users to understand and use the parameters.
>>
>> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
>> ---
>>  Documentation/kernel-parameters.txt |   15 +++++++++++++++
>>  1 files changed, 15 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
>> index 363e348..1fb269b 100644
>> --- a/Documentation/kernel-parameters.txt
>> +++ b/Documentation/kernel-parameters.txt
>> @@ -2227,6 +2227,21 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>>  				This sorting is done to get a device
>>  				order compatible with older (<= 2.4) kernels.
>>  		nobfsort	Don't sort PCI devices into breadth-first order.
>> +		pcie_bus_tune_off	Disable PCI-E MPS turning and using
>> +				the BIOS configured MPS defaults.
> 
> 				    BIOS-configured

Will update it.

> 
>> +		pcie_bus_safe	Use the smallest common denominator MPS
>> +				of the entire tree below a root complex for every device
>> +				on that fabric. Can avoid inconsistent mps problem caused
> 
> s/mps/MPS/
> i.e., use "MPS" consistently.

Will use mps consistently.

> 
>> +				by hotplug.
>> +		pcie_bus_perf	Configure pcie device MPS to the largest allowable
>> +				MPS based on its parent bus. And also set MRRS to the
> 
> "And also" is redundant.  Just say Also.

Ok.

> 
> What is (are) MRRS?

MRRS is "Max Read Request Size" and MPS is "Max Payload Size".
Need use "Max Read Request Size" instead of MRRS ?

> 
>> +				largest supported value but cannot be configured larger
>> +				than the MPS the device or the bus can support for Max
>> +				performance.
>> +		pcie_bus_peer2peer	Make the system wide MPS the smallest
> 
> 					         system-wide

Will update it.

> 
>> +				possible value (128B).This configuration could prevent it
> 
> 				                      ^ Space before "This"
> 

Thanks for reminder.

>> +				from working by having the MPS on one root port different
>> +				than the MPS on another.
>>  		cbiosize=nn[KMG]	The fixed amount of bus space which is
>>  				reserved for the CardBus bridge's IO window.
>>  				The default value is 256 bytes.
>>
> 
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/