Re: [PATCH] CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 22 Jan 2013 14:21:03 -0500
> Kyle McMartin <kyle@xxxxxxxxxx> wrote:
> 
> > CONFIG_EXPERT is a bit silly a place for this, and hides it
> > unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.
> > 
> > Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxx>
> > 
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
> >  	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
> >  
> >  config PANIC_ON_OOPS
> > -	bool "Panic on Oops" if EXPERT
> > +	bool "Panic on Oops" if DEBUG_KERNEL
> >  	default n
> >  	help
> >  	  Say Y here to enable the kernel to panic when it oopses. This
> 
> hm, I'm not sure that it should depend on anything.  Where's the benefit?

Agreed.

(The 'default n' is superfuous as well, while at it.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/