Re: [PATCH 2/2] regulator: tps65910: Fix using wrong dev argumentfor calling of_regulator_match

[gg]

On 2013-01-23 20:45, Laxman Dewangan wrote:
> On Thursday 24 January 2013 08:01 AM, Axel Lin wrote:
> > The dev parameter is the device requesting the data.
> > In this case it should be &pdev->dev rather than pdev->dev.parent.
> >
> > The dev parameter is used to call devm_kzalloc in 
> > of_get_regulator_init_data(),
> > which means this fixes a memory leak because the memory is allocated 
> > every time
> > probe() is called, thus it should be freed when this driver is 
> > unloaded.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> > ---
>
> Agree with the change.
> Acked-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>

Also agree.

Acked-by: Graeme Gregory <gg@xxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/