Re: [PATCH v2 15/17] workqueue: remove global_cwq

From: Tejun Heo
Date: Thu Jan 24 2013 - 13:44:51 EST


Hey, Joonsoo.

On Thu, Jan 24, 2013 at 06:29:36PM +0900, Joonsoo Kim wrote:
> > -static DEFINE_PER_CPU(struct global_cwq, global_cwq);
> > +static DEFINE_PER_CPU(struct worker_pool [NR_STD_WORKER_POOLS],
> > + cpu_std_worker_pools);
> > static DEFINE_PER_CPU_SHARED_ALIGNED(atomic_t, pool_nr_running[NR_STD_WORKER_POOLS]);
>
> AFAIK, worker_pool can be accessed by other cpus.
> So, I think that we also need "DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [], xxx)".

Hmmm... yean. I think I'll just move pool_nr_running into
worker_pool. Will prep a separate patch.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/