Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb partof control module

[kishon]

On Friday 25 January 2013 02:15 PM, Felipe Balbi wrote:
> hi,
>
> On Fri, Jan 25, 2013 at 02:12:41PM +0530, kishon wrote:
> > On Friday 25 January 2013 01:18 PM, Felipe Balbi wrote:
> > > On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote:
> > > > On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote:
> > > > > Added a new driver for the usb part of control module. This has an API
> > > > > to power on the USB2 phy and an API to write to the mailbox depending on
> > > > > whether MUSB has to act in host mode or in device mode.
> > > > >
> > > > > Writing to control module registers for doing the above task which was
> > > > > previously done in omap glue and in omap-usb2 phy will be removed.
> > > >
> > > > > diff --git a/Documentation/devicetree/bindings/usb/usb-phy.txt b/Documentation/devicetree/bindings/usb/usb-phy.txt
> > > >
> > > > This file seems to be specific to the TI USB PHYs, not all USB PHYs;
> > > > shouldn't it be renamed ti-usb-phy.txt, or even better renamed to match
> > > > the compatible value it documents, giving ti,omap-usb2.txt?
> > >
> > > could be, but that can be done as a separate patch. It's not part of
> > > $SUBJECT.
> > >
> > > > >   add the address of control module dev conf register until a driver for
> > > > >   control module is added
> > > > >
> > > > > +Optional properties:
> > > > > + - ctrl_module : phandle of the control module used by PHY driver to power on
> > > > > +   the PHY.
> > > >
> > > > DT property names generally use - not _ as the word separator.
> > >
> > > fair enough, Kishon, can you fix this up ?
> >
> > Sure. Will post a patch..
>
> Great, notice that I've already applied some of your patches to my tree.
Cool. Thanks :-)

Regards
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/